Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21826: Update System Checks to separate links to Domain Address … #11756

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

kcristiano
Copy link
Member

…and From Email Address settings pages


Overview

Update System Status Screen to have separate links for Domain Name and From Email Address

Before

#11047 removed the default FROM Email Address from the Domaon Organizational Contact Screen. The system check did not reflect this

After

Now the system check will link to the proper pages based on the status

Technical Details

None

Comments

…nd From Email Address settings pages

----------------------------------------
* CRM-21826: Default FROM Email Address (for system-generated emails) link incorrect in System Status Screen
  https://issues.civicrm.org/jira/browse/CRM-21826
@seamuslee001
Copy link
Contributor

(CiviCRM Review Template WORD-1.1)

  • (r-explain) Pass
  • (r-test) Pass
  • (r-code) Pass
  • (r-doc) Pass
  • (r-maint) Pass
  • (r-run) Pass - I was able to replicate the problem using the basic demo site, i altered the email address so it would be picked up, I then was able to see that the URL for the fix email was incorrect, Upon applying this PR can confirm the url for the fix email url is now correct and points at the from email address list.
  • (r-user) Pass
  • (r-tech) Pass

@seamuslee001 seamuslee001 merged commit 78a4b4c into civicrm:master Mar 5, 2018
@mlutfy mlutfy added this to the 4.7.32 milestone Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants